]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
authPrompt: Call wiggle directly in _onShowMessage
authorJoan Torres Lopez <joantolo@redhat.com>
Tue, 5 May 2026 19:32:06 +0000 (21:32 +0200)
committerMarge Bot <marge-bot@gnome.org>
Thu, 14 May 2026 18:26:04 +0000 (18:26 +0000)
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4209>

js/gdm/authPrompt.js

index 1d5a5f26b12f03eeeaaad34fea862e34228c072d..e186f8ca1312bb7a97697ad0301daefd7ebc5e69 100644 (file)
@@ -479,21 +479,20 @@ export const AuthPrompt = GObject.registerClass({
     }
 
     _onShowMessage(_userVerifier, serviceName, message, type) {
-        let wiggleParameters = {duration: 0};
+        this.setMessage(message, type);
+        this.emit('prompted');
 
         if (type === GdmUtil.MessageType.ERROR &&
             this._userVerifier.serviceIsFingerprint(serviceName)) {
             // TODO: Use Await for wiggle to be over before unfreezing the user verifier queue
-            wiggleParameters = {
+            const wiggleParameters = {
                 duration: 65,
                 wiggleCount: 3,
             };
             this._userVerifier.increaseCurrentMessageTimeout(
                 wiggleParameters.duration * (wiggleParameters.wiggleCount + 2));
+            wiggle(this._message, wiggleParameters);
         }
-
-        this.setMessage(message, type, wiggleParameters);
-        this.emit('prompted');
     }
 
     _onVerificationFailed(userVerifier, serviceName, canRetry) {
@@ -667,7 +666,7 @@ export const AuthPrompt = GObject.registerClass({
         });
     }
 
-    setMessage(message, type, wiggleParameters = {duration: 0}) {
+    setMessage(message, type) {
         if (type === GdmUtil.MessageType.ERROR)
             this._message.add_style_class_name('login-dialog-message-warning');
         else
@@ -687,8 +686,6 @@ export const AuthPrompt = GObject.registerClass({
         } else {
             this._message.opacity = 0;
         }
-
-        wiggle(this._message, wiggleParameters);
     }
 
     updateSensitivity(sensitive) {